Only check inactive replicas in cancelling existing recoveries.#60564
Merged
henningandersen merged 3 commits intoelastic:masterfrom Sep 3, 2021
Merged
Only check inactive replicas in cancelling existing recoveries.#60564henningandersen merged 3 commits intoelastic:masterfrom
henningandersen merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
Contributor
|
Related to #46520 |
Contributor
|
@elasticmachine update branch |
Collaborator
|
user doesn't have permission to update head repository |
Contributor
|
@elasticmachine test this please |
Contributor
Author
|
Branch has been updated. Thank you @henningandersen . |
Contributor
Author
|
Hi @henningandersen would you please help to check this PR again? Thank you. |
Contributor
|
@elasticmachine test this please |
Contributor
Author
|
Merged latest master. |
Contributor
|
@elasticmachine test this please |
henningandersen
approved these changes
Sep 3, 2021
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
henningandersen
pushed a commit
that referenced
this pull request
Sep 3, 2021
Minor performance improvement when only primaries are initializing.
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Sep 4, 2021
* master: (128 commits) Mute DieWithDignityIT (elastic#77283) Fix randomization in MlNodeShutdownIT (elastic#77281) Add target_node_name for REPLACE shutdown type (elastic#77151) [DOCS] Adds information about version compatibility headers (elastic#77096) Fix template equals when mappings are wrapped (elastic#77008) Fix TextFieldMapper Retaining a Reference to its Builder (elastic#77251) Move die with dignity to be a test module (elastic#77136) Update task names for rest compatiblity (elastic#75267) [ML] adjusting bwc serialization for elastic#77256 (elastic#77257) Move `index.hidden` from Static to Dynamic settings (elastic#77218) Handle cgroups v2 in `OsProbe` (elastic#77128) Choose postings format from FieldMapper instead of MappedFieldType (elastic#77234) Add segment sorter for data streams (elastic#75195) Update skip after backport (elastic#77212) [ML] adding new defer_definition_decompression parameter to put trained model API (elastic#77189) [ML] Fix bug in inference stats persister for when feature reset is called Only check replicas in cancelling existing recoveries. (elastic#60564) Format `AbstractFilteringTestCase` (elastic#77217) [DOCS] Fixes line breaks. (elastic#77248) Convert 'routing' values in REST API tests to strings ... # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we check and process existing recoveries once we have
INITIALIZINGshards.ReplicaShardAllocator.processExistingRecoverieswould be expensive as it will for-loop all the shards overall the nodes. Actually we only need to do this checking if we do have replicas inINITIALIZINGstate. If we only have primaries in this state, we could skip. For example:INITIALIZINGprimaries, we don't need to process existing recoveries, as no replicas would be allocated at the begining.