Skip to content

Avoid using string 'y' in fields REST tests.#60471

Merged
jtibshirani merged 1 commit intoelastic:masterfrom
jtibshirani:fields-rest-tests
Jul 31, 2020
Merged

Avoid using string 'y' in fields REST tests.#60471
jtibshirani merged 1 commit intoelastic:masterfrom
jtibshirani:fields-rest-tests

Conversation

@jtibshirani
Copy link
Copy Markdown
Contributor

Some yaml parsers interpret 'y' and 'yes' as the boolean 'true'.

Some yaml parsers interpret 'y' and 'yes' as the boolean 'true'.
@jtibshirani jtibshirani added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Jul 30, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Search)

@karmi
Copy link
Copy Markdown
Contributor

karmi commented Jul 31, 2020

Thanks!

Copy link
Copy Markdown
Contributor

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani jtibshirani merged commit 74b56f3 into elastic:master Jul 31, 2020
@jtibshirani jtibshirani deleted the fields-rest-tests branch July 31, 2020 16:09
jtibshirani added a commit that referenced this pull request Jul 31, 2020
Some yaml parsers interpret 'y' and 'yes' as the boolean 'true'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants