Improve 'ignore_malformed' handling for dates#60211
Merged
cbuescher merged 1 commit intoelastic:masterfrom Aug 17, 2020
Merged
Conversation
Currently we occasionally can get ArithmeticException from parsing bad input values on 'date' fields that are passed on even if 'ignore_malformed' is set. This change adds this exception to the ones we already catch for malformed values. Closes elastic#52634
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
jtibshirani
approved these changes
Jul 31, 2020
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
The fix makes sense to me. It's too bad that Java time can produce an ArithmeticException during conversion.
cbuescher
pushed a commit
that referenced
this pull request
Aug 17, 2020
Currently we occasionally can get ArithmeticException from parsing bad input values on 'date' fields that are passed on even if 'ignore_malformed' is set. This change adds this exception to the ones we already catch for malformed values. Closes #52634
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we occasionally can get ArithmeticException from parsing bad input
values on 'date' fields that are passed on even if 'ignore_malformed' is set.
This change adds this exception to the ones we already catch for malformed
values.
Closes #52634