Fix indexing pressure replica rejections logic#60150
Merged
Tim-Brooks merged 1 commit intoelastic:masterfrom Jul 27, 2020
Merged
Fix indexing pressure replica rejections logic#60150Tim-Brooks merged 1 commit intoelastic:masterfrom
Tim-Brooks merged 1 commit intoelastic:masterfrom
Conversation
Currently the logic to rejection replica rejections is evaluate before adding the additional bytes of the current operation. This means that the first replica operation which should be rejected will be allowed to proceed. This commit fixes this logic and adds unit level test to ensure indexing pressure behavior is correct.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
13 tasks
Tim-Brooks
added a commit
that referenced
this pull request
Jul 27, 2020
Currently the logic to rejection replica rejections is evaluate before adding the additional bytes of the current operation. This means that the first replica operation which should be rejected will be allowed to proceed. This commit fixes this logic and adds unit level test to ensure indexing pressure behavior is correct.
Tim-Brooks
added a commit
that referenced
this pull request
Jul 27, 2020
Currently the logic to rejection replica rejections is evaluate before adding the additional bytes of the current operation. This means that the first replica operation which should be rejected will be allowed to proceed. This commit fixes this logic and adds unit level test to ensure indexing pressure behavior is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the logic to rejection replica rejections is evaluate before
adding the additional bytes of the current operation. This means that
the first replica operation which should be rejected will be allowed to
proceed. This commit fixes this logic and adds unit level test to ensure
indexing pressure behavior is correct.