Fix handling of final pipelines when destination is changed#59522
Merged
probakowski merged 10 commits intoelastic:masterfrom Jul 16, 2020
Merged
Fix handling of final pipelines when destination is changed#59522probakowski merged 10 commits intoelastic:masterfrom
probakowski merged 10 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
martijnvg
reviewed
Jul 15, 2020
Member
martijnvg
left a comment
There was a problem hiding this comment.
Thanks @probakowski! Left a few comments.
Also I don't think the following scenarios are tested:
- if request/default pipeline changes destination final pipeline from old index won't be executed
- if request/default pipeline changes destination and new index has final pipeline it will be executed default pipeline from new index won't be executed
So maybe add a test for that? I think a unit test is tricky, but an integration test should be possible.
server/src/main/java/org/elasticsearch/ingest/IngestService.java
Outdated
Show resolved
Hide resolved
| Iterator<String> newIt = it; | ||
| boolean newHasFinalPipeline = hasFinalPipeline; | ||
|
|
||
| if (oldIndex.equals(indexRequest.indices()[0]) == false && state != null) { |
Member
There was a problem hiding this comment.
I think if state is null then an error should be returned? If a node has been started and is ready to accept requests then all components like IngestService should have been provided a cluster state.
Contributor
Author
There was a problem hiding this comment.
I removed the check, as you said state should be always filled, if not we have deeper problem here. WDYT?
Member
There was a problem hiding this comment.
Yes, then there is a deeper problem elsewhere.
But that is not related to ingest or bulk.
server/src/main/java/org/elasticsearch/ingest/IngestService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/ingest/IngestService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/ingest/IngestService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for review @martijnvg! |
Contributor
Author
|
@elasticmachine update branch |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Jul 17, 2020
…59522) This change fixes final pipelines if destination index is changed during pipeline run: -final pipelines can't change destination anymore, exception is thrown if they try to -if request/default pipeline changes destination final pipeline from old index won't be executed -if request/default pipeline changes destination and new index has final pipeline it will be executed -default pipeline from new index won't be executed Additionally TransportBulkAction.resolvePipelines was moved to IngestService as it's needed for resolving pipelines from new index. Tests were moved accordingly. Closes elastic#57968
probakowski
added a commit
that referenced
this pull request
Jul 17, 2020
…9522) (#59746) * Fix handling of final pipelines when destination is changed (#59522) This change fixes final pipelines if destination index is changed during pipeline run: -final pipelines can't change destination anymore, exception is thrown if they try to -if request/default pipeline changes destination final pipeline from old index won't be executed -if request/default pipeline changes destination and new index has final pipeline it will be executed -default pipeline from new index won't be executed Additionally TransportBulkAction.resolvePipelines was moved to IngestService as it's needed for resolving pipelines from new index. Tests were moved accordingly. Closes #57968
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Jul 17, 2020
…astic#59522) (elastic#59746) * Fix handling of final pipelines when destination is changed (elastic#59522) This change fixes final pipelines if destination index is changed during pipeline run: -final pipelines can't change destination anymore, exception is thrown if they try to -if request/default pipeline changes destination final pipeline from old index won't be executed -if request/default pipeline changes destination and new index has final pipeline it will be executed -default pipeline from new index won't be executed Additionally TransportBulkAction.resolvePipelines was moved to IngestService as it's needed for resolving pipelines from new index. Tests were moved accordingly. Closes elastic#57968
probakowski
added a commit
that referenced
this pull request
Jul 17, 2020
…9522) (#59756) * Fix handling of final pipelines when destination is changed (#59522) This change fixes final pipelines if destination index is changed during pipeline run: -final pipelines can't change destination anymore, exception is thrown if they try to -if request/default pipeline changes destination final pipeline from old index won't be executed -if request/default pipeline changes destination and new index has final pipeline it will be executed -default pipeline from new index won't be executed Additionally TransportBulkAction.resolvePipelines was moved to IngestService as it's needed for resolving pipelines from new index. Tests were moved accordingly. Closes #57968
This has broken all of my ingest pipelines, but is not called out as a breaking change. |
This was referenced Aug 26, 2021
This was referenced Dec 15, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes final pipelines if destination index is changed during pipeline run:
Additionally
TransportBulkAction.resolvePipelineswas moved toIngestServiceas it's needed for resolving pipelines from new index. Tests were moved accordingly.Closes #57968