Separate coordinating and primary bytes in stats#59487
Merged
Tim-Brooks merged 5 commits intoelastic:masterfrom Jul 14, 2020
Merged
Separate coordinating and primary bytes in stats#59487Tim-Brooks merged 5 commits intoelastic:masterfrom
Tim-Brooks merged 5 commits intoelastic:masterfrom
Conversation
Currently we combine coordinating and primary bytes into a single bucket for indexing pressure stats. This makes sense for rejection logic. However, for metrics it would be useful to separate them.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
13 tasks
ywelsch
reviewed
Jul 14, 2020
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
I've left some minor comments, looking good o.w.
...r/src/main/java/org/elasticsearch/action/support/replication/TransportReplicationAction.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/support/replication/TransportReplicationAction.java
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/support/replication/TransportReplicationAction.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/support/replication/TransportReplicationAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/support/replication/TransportWriteAction.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
After discussing with @ywelsch - I am merging this PR. |
Tim-Brooks
added a commit
that referenced
this pull request
Jul 14, 2020
Currently we combine coordinating and primary bytes into a single bucket for indexing pressure stats. This makes sense for rejection logic. However, for metrics it would be useful to separate them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we combine coordinating and primary bytes into a single bucket
for indexing pressure stats. This makes sense for rejection logic.
However, for metrics it would be useful to separate them.