Fix SLM Tests Leaking Snapshot Operation#59150
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Jul 7, 2020
original-brownbear:stabilize-slm-tests-wait
Merged
Fix SLM Tests Leaking Snapshot Operation#59150original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:stabilize-slm-tests-wait
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:stabilize-slm-tests-wait
Conversation
Fixed an issue #59082 introduced. We have to wait for no more operations in all tests here not just the one we were waiting in already so that the cleanup operation from the parent class can run without failure.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
tlrx
approved these changes
Jul 7, 2020
Contributor
Author
|
Thanks Tanguy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue #59082 introduced. We have to wait for no more operations
in all tests here not just the one we were waiting in already so that the cleanup
operation from the parent class can run without failure.
Ran into this in a PR and can reproduce at low rate locally as well: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-2/3390/testReport/junit/org.elasticsearch.xpack.slm/SLMSnapshotBlockingIntegTests/testSLMRetentionAfterRestore/