Skip to content

Percolator keyword fields should not store norms#58899

Merged
romseygeek merged 2 commits intoelastic:masterfrom
romseygeek:bug/binary-norms
Jul 2, 2020
Merged

Percolator keyword fields should not store norms#58899
romseygeek merged 2 commits intoelastic:masterfrom
romseygeek:bug/binary-norms

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

The refactoring in #57666 inadvertently enabled norms on two of the percolator subfields,
leading to an increase in memory usage. This commit disables norms on these fields again.

@romseygeek romseygeek added >non-issue :Search Relevance/Percolator Reverse search: find queries that match a document v8.0.0 v7.9.0 labels Jul 2, 2020
@romseygeek romseygeek self-assigned this Jul 2, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Percolator)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 2, 2020
@romseygeek
Copy link
Copy Markdown
Contributor Author

Marked as a non-issue because unreleased.

Copy link
Copy Markdown
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 6734440 into elastic:master Jul 2, 2020
@romseygeek romseygeek deleted the bug/binary-norms branch July 2, 2020 12:59
romseygeek added a commit that referenced this pull request Jul 2, 2020
The refactoring in #57666 inadvertently enabled norms on two of the percolator subfields,
leading to an increase in memory usage. This commit disables norms on these fields again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search Relevance/Percolator Reverse search: find queries that match a document Team:Search Meta label for search team v7.9.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants