Add test assertions to ensure write bytes released#58566
Merged
Tim-Brooks merged 2 commits intoelastic:masterfrom Jun 26, 2020
Merged
Add test assertions to ensure write bytes released#58566Tim-Brooks merged 2 commits intoelastic:masterfrom
Tim-Brooks merged 2 commits intoelastic:masterfrom
Conversation
This is a follow-up to elastic#57573. This commit ensures that the bytes marked in `WriteMemoryLimits` are released by any test using an internal test cluster.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
henningandersen
approved these changes
Jun 26, 2020
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
Maybe trigger an additional test run for verification, since this check depends on correctness of many pieces.
…bytes_released_in_tests
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Jul 2, 2020
This is a follow-up to elastic#57573. This commit ensures that the bytes marked in `WriteMemoryLimits` are released by any test using an internal test cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #57573. This commit ensures that the bytes marked
in
WriteMemoryLimitsare released by any test using an internal testcluster.