Fix passing params to template or script failed in watcher#58559
Merged
jakelandis merged 2 commits intoelastic:masterfrom Sep 2, 2020
Merged
Fix passing params to template or script failed in watcher#58559jakelandis merged 2 commits intoelastic:masterfrom
jakelandis merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
Contributor
|
@elasticmachine update branch |
Collaborator
|
merge conflict between base and head |
Contributor
|
@elasticmachine ok to test |
jakelandis
approved these changes
Sep 2, 2020
Contributor
jakelandis
left a comment
There was a problem hiding this comment.
changes look good. thanks @gaobinlong !
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Sep 2, 2020
…8559) The main changes are: * Fix custom params are missing when using template or script in watcher's logging action or jira action. * Add yaml tests to test passing params to template or script successfully. Relates to elastic#57625
Contributor
|
Nice! |
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #57625.
The main changes are: