Use clean thread context for transport and applier service#57792
Merged
ywelsch merged 4 commits intoelastic:masterfrom Jun 9, 2020
Merged
Use clean thread context for transport and applier service#57792ywelsch merged 4 commits intoelastic:masterfrom
ywelsch merged 4 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Network) |
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
Looks much nicer now thanks, just one question on the network side of things.
ywelsch
added a commit
that referenced
this pull request
Jun 9, 2020
Adds assertions to Netty to make sure that its threads are not polluted by thread contexts (and also that thread contexts are not leaked). Moves the ClusterApplierService to use the system context (same as we do for MasterService), which allows to remove a hack from TemplateUgradeService and makes it clearer that applying CS updates is fully executing under system context.
ywelsch
added a commit
that referenced
this pull request
Jun 9, 2020
Only assert that actual request headers are empty, as default headers might still be there when stashing the context.
ywelsch
added a commit
that referenced
this pull request
Jun 9, 2020
Only assert that actual request headers are empty, as default headers might still be there when stashing the context.
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Jun 10, 2020
…7792) Adds assertions to Netty to make sure that its threads are not polluted by thread contexts (and also that thread contexts are not leaked). Moves the ClusterApplierService to use the system context (same as we do for MasterService), which allows to remove a hack from TemplateUgradeService and makes it clearer that applying CS updates is fully executing under system context.
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Jun 10, 2020
Only assert that actual request headers are empty, as default headers might still be there when stashing the context.
ywelsch
added a commit
that referenced
this pull request
Jun 10, 2020
…57914) Adds assertions to Netty to make sure that its threads are not polluted by thread contexts (and also that thread contexts are not leaked). Moves the ClusterApplierService to use the system context (same as we do for MasterService), which allows to remove a hack from TemplateUgradeService and makes it clearer that applying CS updates is fully executing under system context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds assertions to Netty to make sure that its threads are not polluted by thread contexts (and also that thread contexts are not leaked). Moves the
ClusterApplierServiceto use the system context (same as we do forMasterService), which allows to remove a hack fromTemplateUgradeServiceand makes it clearer that applying CS updates is fully executing under system context.