[DOCS] Reformat pattern_replace token filter#57699
Merged
jrodewig merged 5 commits intoelastic:masterfrom Jun 11, 2020
jrodewig:docs__reformat-pattern-replace-tokenfilter
Merged
[DOCS] Reformat pattern_replace token filter#57699jrodewig merged 5 commits intoelastic:masterfrom jrodewig:docs__reformat-pattern-replace-tokenfilter
pattern_replace token filter#57699jrodewig merged 5 commits intoelastic:masterfrom
jrodewig:docs__reformat-pattern-replace-tokenfilter
Conversation
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Adds parameter definitions * Adds custom analyzer example
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
82 tasks
pattern_replace tokenfilterpattern_replace token filter docs
pattern_replace token filter docspattern_replace token filter
markharwood
reviewed
Jun 8, 2020
| The `my_pattern_replace_filter` filter uses the regular expression `\\p{Sc}` to | ||
| match and remove currency symbols, such as `£`, `€`, or `$`. The filter's `all` | ||
| parameter is `false`, meaning only the first matching symbol in each token is | ||
| removed. |
Contributor
There was a problem hiding this comment.
I did not know \\p{Sc} was a thing so thanks for educating me :)
While these more esoteric functions work in token filters they are not supported in RegExp query syntax.
I wonder if it's worth doing one of two things here:
A) Add a footnote to the effect of "* note this particular expression wouldn't work with RegExp queries which use a different regex parser" or
B) Use a different example that works in both "pattern_replace" token filters and RegExp queries.
Contributor
Author
There was a problem hiding this comment.
Thanks @markharwood. With 992ab1c, I updated the example to use a pattern that compatible with the RegExp query.
markharwood
approved these changes
Jun 11, 2020
Contributor
markharwood
left a comment
There was a problem hiding this comment.
LGTM.
Thanks, @jrodewig
Contributor
Author
|
Thanks @markharwood. |
This was referenced Jun 11, 2020
jrodewig
added a commit
that referenced
this pull request
Jun 11, 2020
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Adds parameter definitions * Adds custom analyzer example
jrodewig
added a commit
that referenced
this pull request
Jun 11, 2020
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Adds parameter definitions * Adds custom analyzer example
jrodewig
added a commit
that referenced
this pull request
Jun 11, 2020
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Adds parameter definitions * Adds custom analyzer example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: