Fix Test Failure from Incorrect Mapping Conflict Assertion#57085
Merged
original-brownbear merged 1 commit intoelastic:masterfrom May 23, 2020
original-brownbear:fix-incorrect-ex-assertion
Merged
Fix Test Failure from Incorrect Mapping Conflict Assertion#57085original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:fix-incorrect-ex-assertion
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:fix-incorrect-ex-assertion
Conversation
I think this is a left-over from #56915 where a change in assertion message didn't make it to this very rare-case assertion.
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
romseygeek
approved these changes
May 23, 2020
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing!
Contributor
Author
|
Np + Thanks for reviewing @romseygeek ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a left-over from #56915 where a change in assertion
message didn't make it to this very rare-case assertion.
Failed here https://gradle-enterprise.elastic.co/s/ppxvrwszi2t6g