Serialize Outbound Message on Flush#57084
Merged
original-brownbear merged 4 commits intoelastic:masterfrom May 27, 2020
original-brownbear:even-lazier-writes
Merged
Serialize Outbound Message on Flush#57084original-brownbear merged 4 commits intoelastic:masterfrom original-brownbear:even-lazier-writes
original-brownbear merged 4 commits intoelastic:masterfrom
original-brownbear:even-lazier-writes
Conversation
Follow up to #56961: We can be a little more efficient than just serializing at the IO loop by serializing only when we flush to a channel. This has the advantage that we don't serialize a long queue of messages for a channel that isn't writable for a longer period of time (unstable network, actually writing large volumes of data, etc.). Also, this further reduces the time for which we hold on to the write buffer for a message, making allocations because of an empty page cache recycler pool less likely.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Network) |
DaveCTurner
approved these changes
May 27, 2020
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM assuming that there's only a single thread in play here; I think there is but I'm not 100% familiar with this code.
Requested an assertion that I think would catch any bad threading anyway.
| if (buf == null) { | ||
| buf = Netty4Utils.toByteBuf(context.get()); | ||
| context = null; | ||
| } |
Member
There was a problem hiding this comment.
Can we assert context == null here?
Contributor
Author
There was a problem hiding this comment.
Sure thing, added it. But yes, all of this is happening on a single IO thread thread so this is all safe I think :)
Contributor
Author
|
Thanks David! |
original-brownbear
added a commit
that referenced
this pull request
Jun 4, 2020
Follow up to #56961: We can be a little more efficient than just serializing at the IO loop by serializing only when we flush to a channel. This has the advantage that we don't serialize a long queue of messages for a channel that isn't writable for a longer period of time (unstable network, actually writing large volumes of data, etc.). Also, this further reduces the time for which we hold on to the write buffer for a message, making allocations because of an empty page cache recycler pool less likely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #56961:
We can be a little more efficient than just serializing at the IO loop by serializing
only when we flush to a channel. This has the advantage that we don't serialize a long
queue of messages for a channel that isn't writable for a longer period of time (unstable network,
actually writing large volumes of data, etc.).
Also, this further reduces the time for which we hold on to the write buffer for a message,
making allocations because of an empty page cache recycler pool less likely.