Skip to content

Simplify range query methods for range types.#56976

Merged
jtibshirani merged 1 commit intoelastic:masterfrom
jtibshirani:range-field
May 20, 2020
Merged

Simplify range query methods for range types.#56976
jtibshirani merged 1 commit intoelastic:masterfrom
jtibshirani:range-field

Conversation

@jtibshirani
Copy link
Copy Markdown
Contributor

For me this is easier to follow. It also avoids parsing the query bounds twice.

For me this is easier to follow. It also avoids parsing the query bounds twice.
@jtibshirani jtibshirani added :Search/Search Search-related issues that do not fall into other categories >refactoring v8.0.0 v7.8.1 v7.9.0 labels May 20, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Search)

Copy link
Copy Markdown
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani
Copy link
Copy Markdown
Contributor Author

Thanks for the speedy review.

@jtibshirani jtibshirani merged commit 9a49075 into elastic:master May 20, 2020
@jtibshirani jtibshirani deleted the range-field branch May 20, 2020 18:57
jtibshirani added a commit that referenced this pull request May 20, 2020
For me this is easier to follow. It also avoids parsing the query bounds twice.
jtibshirani added a commit that referenced this pull request May 20, 2020
For me this is easier to follow. It also avoids parsing the query bounds twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>refactoring :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.8.1 v7.9.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants