Skip to content

Add Restore UUID Index Setting#56930

Merged
original-brownbear merged 9 commits intoelastic:masterfrom
original-brownbear:index-retstore-uuid
May 25, 2020
Merged

Add Restore UUID Index Setting#56930
original-brownbear merged 9 commits intoelastic:masterfrom
original-brownbear:index-retstore-uuid

Conversation

@original-brownbear
Copy link
Copy Markdown
Contributor

Pre-requesite for #50278 to be able to uniquely identify index metadata by
its version fields and UUIDs when restoring into closed indices.

See related discussion here: #50278 (comment)

Pre-requesite for #50278 to be able to uniquely identify index metadata by
its version fields and UUIDs when restoring into closed indices.
@original-brownbear original-brownbear added >non-issue :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 v7.9.0 labels May 19, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Distributed)

@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label May 19, 2020
Copy link
Copy Markdown
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should generalize this to an index.history.uuid (which is also updated on dangling indices import, as well as whenever we run the unsafe bootstrap command). This makes this also more generally useful to characterize the identity of the index metadata.

settings.remove(IndexSettings.INDEX_SOFT_DELETES_SETTING.getKey());
settings.remove(IndexMetadata.SETTING_INDEX_VERSION_CREATED.getKey());
settings.remove(IndexMetadata.SETTING_INDEX_UUID);
settings.remove(IndexMetadata.SETTING_RESTORE_UUID);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this setting on clone/split/shrink as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jup makes sense to me => done.

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run elasticsearch-ci/2 (random known aggs failure)

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run elasticsearch-ci/bwc

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Thanks @ywelsch, I renamed the setting as suggested and added the functionality to dangling index import and unsafe bootstraps now.

Copy link
Copy Markdown
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Thanks Yannick!

@original-brownbear original-brownbear merged commit ee56a36 into elastic:master May 25, 2020
@original-brownbear original-brownbear deleted the index-retstore-uuid branch May 25, 2020 08:34
original-brownbear added a commit that referenced this pull request May 25, 2020
Pre-requesite for #50278 to be able to uniquely identify index metadata by
its version fields and UUIDs when restoring into closed indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Distributed Meta label for distributed team. v7.9.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants