EQL: Adds get async EQL search result action#56852
Merged
imotov merged 5 commits intoelastic:feature/async-eqlfrom May 27, 2020
Merged
EQL: Adds get async EQL search result action#56852imotov merged 5 commits intoelastic:feature/async-eqlfrom
imotov merged 5 commits intoelastic:feature/async-eqlfrom
Conversation
Adds support for retrieving async EQL search result s to eql search API. Relates to elastic#49638
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
jimczi
approved these changes
May 25, 2020
Contributor
jimczi
left a comment
There was a problem hiding this comment.
Looks good to me. Can you also add a test for security similar to AsyncSearchSecurityIT ?
costin
reviewed
May 27, 2020
| listener.onResponse(new IndexAuthorizationResult(true, IndicesAccessControl.ALLOW_NO_INDICES)); | ||
| } | ||
| } else if (isAsyncSearchRelatedAction(action)) { | ||
| } else if (isAsyncSearchRelatedAction(action) || isAsyncEqlSearchRelatedAction(action)) { |
Member
There was a problem hiding this comment.
Maybe add a isAsyncAction to encapsulate the condition of both search and eql searches there? Any future updates would not touch authorizeIndexAction.
costin
reviewed
May 27, 2020
Member
costin
left a comment
There was a problem hiding this comment.
Lots of goodies in this PR. I can't comment much on the async bit but otherwise, LGTM.
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
May 27, 2020
Adds support for deleting async EQL search results to eql search API. Relates to elastic#49638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for retrieving async EQL search result s to eql search API.
Relates to #49638