Add template simulation API for simulating template composition#56842
Merged
dakrone merged 6 commits intoelastic:masterfrom May 18, 2020
Merged
Add template simulation API for simulating template composition#56842dakrone merged 6 commits intoelastic:masterfrom
dakrone merged 6 commits intoelastic:masterfrom
Conversation
This adds an API for simulating template composition with or without an index template.
It looks like:
```
POST /_index_template/_simulate/my-template
```
To simulate a template named `my-template` that already exists, or, to simulate a template that does
not already exist:
```
POST /_index_template/_simulate
{
"index_patterns": ["my-index"]
"composed_of": ["ct1", "ct2"],
}
```
This is related to elastic#55686, which adds an API to simulate composition based on an index name (hence
the `_simulate_index` vs `_simulate`).
This commit also adds reference documentation for both simulation APIs.
Relates to elastic#53101
Resolves elastic#56390
Resolves elastic#56255
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
dakrone
commented
May 15, 2020
Comment on lines
-120
to
-122
| .startObject() | ||
| .field(MapperService.SINGLE_MAPPING_NAME, mappings) | ||
| .endObject()); |
Member
Author
There was a problem hiding this comment.
@andreidan I had to remove this wrapping because the simulated documents came back with the _doc parameter in the mappings, and they can't be sent as new component or index templates with _doc in the mappings
Collaborator
|
Pinging @elastic/es-ui (:ES-UI) |
Member
Author
|
This also doesn't include HLRC support (yet), since it's already over 800 lines I figured it should be split into a separate PR. |
Member
Author
|
@elasticmachine test this please |
andreidan
approved these changes
May 18, 2020
Contributor
andreidan
left a comment
There was a problem hiding this comment.
Thanks for adding support for this Lee
This LGTM, left a couple of minor suggestions, but this looks great already
...va/org/elasticsearch/action/admin/indices/template/post/TransportSimulateTemplateAction.java
Outdated
Show resolved
Hide resolved
…mplate/post/TransportSimulateTemplateAction.java Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
Member
Author
|
@elasticmachine update branch |
cjcenizal
reviewed
May 18, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
I just reviewed the docs and had one comment. Thanks for adding this!
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 18, 2020
…tic#56842) This adds an API for simulating template composition with or without an index template. It looks like: ``` POST /_index_template/_simulate/my-template ``` To simulate a template named `my-template` that already exists, or, to simulate a template that does not already exist: ``` POST /_index_template/_simulate { "index_patterns": ["my-index"] "composed_of": ["ct1", "ct2"], } ``` This is related to elastic#55686, which adds an API to simulate composition based on an index name (hence the `_simulate_index` vs `_simulate`). This commit also adds reference documentation for both simulation APIs. Relates to elastic#53101 Resolves elastic#56390 Resolves elastic#56255
dakrone
added a commit
that referenced
this pull request
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an API for simulating template composition with or without an index template.
It looks like:
To simulate a template named
my-templatethat already exists, or, to simulate a template that doesnot already exist:
This is related to #55686, which adds an API to simulate composition based on an index name (hence
the
_simulate_indexvs_simulate).This commit also adds reference documentation for both simulation APIs.
Relates to #53101
Resolves #56390
Resolves #56255