More Efficient Snapshot State Handling#56669
Merged
original-brownbear merged 1 commit intoelastic:masterfrom May 15, 2020
original-brownbear:more-efficient-snapshot-finalization
Merged
More Efficient Snapshot State Handling#56669original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:more-efficient-snapshot-finalization
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:more-efficient-snapshot-finalization
Conversation
Follow up to #56365. Instead of redundantly checking snapshots for completion over and over, just track the completed snapshots in the CS updates that complete them instead of looping over the smae snapshot entries over and over. Also, in the batched snapshot shard status updates, only check for completion of a snapshot entry if it isn't already finalizing.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
| try { | ||
| listener.onResponse(new UpdateIndexShardSnapshotStatusResponse()); | ||
| } finally { | ||
| endCompletedSnapshots(newState); |
Contributor
Author
There was a problem hiding this comment.
This saves a ton of cycles. Just think about a 10k shards snapshot. Worst case that would have triggered ~10k ^ 2 checks on whether all shards have completed if the last snapshot update ...
Contributor
Author
|
Thanks Tanguy! |
original-brownbear
added a commit
that referenced
this pull request
Jul 13, 2020
Follow up to #56365. Instead of redundantly checking snapshots for completion over and over, just track the completed snapshots in the CS updates that complete them instead of looping over the smae snapshot entries over and over. Also, in the batched snapshot shard status updates, only check for completion of a snapshot entry if it isn't already finalizing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #56365. Instead of redundantly checking snapshots for completion
over and over, just track the completed snapshots in the CS updates that complete
them instead of looping over the smae snapshot entries over and over.
Also, in the batched snapshot shard status updates, only check for completion
of a snapshot entry if it isn't already finalizing.