Report used memory as zero when total memory cannot be obtained#56435
Merged
danhermann merged 1 commit intoelastic:masterfrom May 8, 2020
Merged
Report used memory as zero when total memory cannot be obtained#56435danhermann merged 1 commit intoelastic:masterfrom
danhermann merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Stats) |
Contributor
Author
|
@elasticsearch run elasticsearch-ci/2 |
Contributor
Author
|
Reviewed and approved in #56412 |
This was referenced May 18, 2020
This was referenced May 28, 2020
This was referenced Feb 4, 2021
This was referenced Jun 1, 2021
williamrandolph
added a commit
that referenced
this pull request
Jun 1, 2021
We've had a series of bug fixes for cases where an OsProbe gives negative values, most often just -1, to the OsStats class. We added assertions to catch cases where we were initializing OsStats with bad values. Unfortunately, these fixes turned to not be backwards-compatible. In this commit, we simply coerce bad values to 0 when data is coming from nodes that don't have the relevant bug fixes. Relevant PRs: * #42725 * #56435 * #57317 Fixes #73459
williamrandolph
added a commit
that referenced
this pull request
Jun 1, 2021
We've had a series of bug fixes for cases where an OsProbe gives negative values, most often just -1, to the OsStats class. We added assertions to catch cases where we were initializing OsStats with bad values. Unfortunately, these fixes turned to not be backwards-compatible. In this commit, we simply coerce bad values to 0 when data is coming from nodes that don't have the relevant bug fixes. Relevant PRs: * #42725 * #56435 * #57317 Fixes #73459
williamrandolph
added a commit
that referenced
this pull request
Jun 1, 2021
We've had a series of bug fixes for cases where an OsProbe gives negative values, most often just -1, to the OsStats class. We added assertions to catch cases where we were initializing OsStats with bad values. Unfortunately, these fixes turned to not be backwards-compatible. In this commit, we simply coerce bad values to 0 when data is coming from nodes that don't have the relevant bug fixes. Relevant PRs: * #42725 * #56435 * #57317 Fixes #73459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing test failures in 7.x on debian8 (though I have not been able to reproduce them) with negative values for used memory which we compute as
total - free. We already coerce both total and free memory to zero if negative values are reported for either because @dakrone's work in #42725 demonstrated that negative values can be returned. That said, it does not appear that those occurrences necessarily coincide such that total may be reported as negative but free is reported as positive thus resulting in a potentialfree > totalsituation.Fixes #54415