Validate V2 templates more strictly#56170
Merged
dakrone merged 4 commits intoelastic:masterfrom May 5, 2020
Merged
Conversation
This commit changes the validation for V2 index and component templates to re-use the same validation that V1 templates used. This includes things like invalid template names, index patterns, etc. This also adds validation that template names do not contain `*`. Supercedes elastic#53970 Relates to elastic#53101
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
andreidan
approved these changes
May 5, 2020
Contributor
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this Lee
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
probakowski
reviewed
May 5, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
cbuescher
reviewed
May 5, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Show resolved
Hide resolved
Member
Author
|
@elasticmachine update branch |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 5, 2020
This commit changes the validation for V2 index and component templates to re-use the same validation that V1 templates used. This includes things like invalid template names, index patterns, etc. This also adds validation that template names do not contain `*` and index patterns do not contain `:` (index names can't contain this regardless). Supercedes elastic#53970 Relates to elastic#53101 Resolves elastic#43737 Resolves elastic#46045
dakrone
added a commit
that referenced
this pull request
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the validation for V2 index and component templates to re-use the same
validation that V1 templates used. This includes things like invalid template names, index patterns,
etc.
This also adds validation that template names do not contain
*and index patterns do not contain:(index names can't contain this regardless).Supercedes #53970
Relates to #53101
Resolves #43737
Resolves #46045