Skip to content

Simplify the ValuesSourceRegistry structure#56154

Merged
imotov merged 1 commit intoelastic:masterfrom
imotov:follow-up-55747-registry-cleanup
May 5, 2020
Merged

Simplify the ValuesSourceRegistry structure#56154
imotov merged 1 commit intoelastic:masterfrom
imotov:follow-up-55747-registry-cleanup

Conversation

@imotov
Copy link
Copy Markdown
Contributor

@imotov imotov commented May 4, 2020

Follow up to #55747.

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
Copy link
Copy Markdown
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imotov imotov merged commit 35aef8b into elastic:master May 5, 2020
imotov added a commit to imotov/elasticsearch that referenced this pull request May 5, 2020
imotov added a commit that referenced this pull request May 5, 2020
@imotov imotov deleted the follow-up-55747-registry-cleanup branch May 5, 2020 14:38
@not-napoleon
Copy link
Copy Markdown
Member

Late to the game, but this looks good to me too. Thanks for cleaning that up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.8.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants