SQL: relax version lock between server and clients#56148
SQL: relax version lock between server and clients#56148bpintea merged 3 commits intoelastic:masterfrom
Conversation
Allow older-than-server clients to connect, if these are past or on a certain min release.
|
Pinging @elastic/es-ql (:Query Languages/SQL) |
matriv
left a comment
There was a problem hiding this comment.
LGTM. Left a minor comment.
| do { | ||
| prepareResponse(version); | ||
|
|
||
| String url = JdbcConfiguration.URL_PREFIX + webServerAddress(); |
There was a problem hiding this comment.
Those can be outside of the loop no?
and probably the whole try - catch can "wrap" the loop?
There was a problem hiding this comment.
Yes, you're right, thanks!
astefan
left a comment
There was a problem hiding this comment.
LGTM. Left one question, though.
| return validationException; | ||
| } | ||
|
|
||
| protected boolean isClientCompatible() { |
There was a problem hiding this comment.
Do you think this method better belongs to SqlVersion class where hasVersionCompatibility() is also defined?
There was a problem hiding this comment.
Yeh, I had a hesitation initially, but it does belong there more naturally. Thanks for raising it.
- refactor VersionParityTests#testNoExceptionThrownForCompatibleVersions to take idempotent assignments and try-catch blocks out a loop. - move method that establishes version compatibiltiy into SqlVersion.
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine run elasticsearch-ci/default-distro |
|
@elasticmachine update branch |
|
user doesn't have permission to update head repository |
* Relax version lock between ES/SQL and clients Allow older-than-server clients to connect, if these are past or on a certain min release. (cherry picked from commit 108f907)
This PR is to allow older-than-server clients to connect, if these are past or on a
certain min release,
7.7.0.Note: the check is currently lower bounded only and subject to later adjustment to
major minus onelimitation.