Allow Bulk Snapshot Deletes to Abort#56009
Merged
original-brownbear merged 1 commit intoelastic:masterfrom May 4, 2020
original-brownbear:one-stop-delete
Merged
Allow Bulk Snapshot Deletes to Abort#56009original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:one-stop-delete
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:one-stop-delete
Conversation
Making use of #55773 to simplify snapshot state machine. 1. Deletes with no in-progress snapshot now add the delete entry to the cluster state right away instead of doing a second CS update after the fist update was a NOOP. 2. If a bulk delete matches in-progress as well as completed snapshots, abort the in-progress snapshot and then move on to delete from the repository.
Contributor
Author
|
Jenkins test this |
Contributor
Author
|
Thanks Tanguy! |
original-brownbear
added a commit
that referenced
this pull request
May 4, 2020
Making use of #55773 to simplify snapshot state machine. 1. Deletes with no in-progress snapshot now add the delete entry to the cluster state right away instead of doing a second CS update after the fist update was a NOOP. 2. If a bulk delete matches in-progress as well as completed snapshots, abort the in-progress snapshot and then move on to delete from the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making use of #55773 to simplify snapshot state machine.
instead of doing a second CS update after the fist update was a NOOP.
NOTE: I didn't refactor things significantly in this PR for now to keep the change-set limited but there's a number of possible follow-ups here to simplify the state update task nesting away and make things much easier to read.