Add HLRC support for simulate index template api#55936
Merged
andreidan merged 8 commits intoelastic:masterfrom Apr 30, 2020
Merged
Add HLRC support for simulate index template api#55936andreidan merged 8 commits intoelastic:masterfrom
andreidan merged 8 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
dakrone
approved these changes
Apr 29, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left two minor comments, thanks Andrei!
| * Set the index name to simulate template matching against the index templates in the system. | ||
| */ | ||
| public SimulateIndexTemplateRequest indexName(String indexName) { | ||
| this.indexName = indexName; |
Member
There was a problem hiding this comment.
We validate the indexName in the constructor but maybe we should also validate it here?
| } | ||
|
|
||
| @Override | ||
| public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException { |
Member
There was a problem hiding this comment.
It seems strange to have a toXContent that produces a body that isn't actually what gets sent (since we don't include the index name in the request body for simulation), do we actually need this method? Can we remove it entirely?
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 30, 2020
(cherry picked from commit 475790c) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
that referenced
this pull request
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #53101