Disk decider respect watermarks for single data node#55805
Merged
henningandersen merged 1 commit intoelastic:masterfrom Apr 28, 2020
Merged
Conversation
The disk decider had special handling for the single data node case, allowing any allocation (skipping watermark checks) for such clusters. This special handling can now be avoided via a setting.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
jasontedor
approved these changes
Apr 27, 2020
Member
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. We'll need to follow up in Cloud to deploy with this setting set to true.
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Apr 28, 2020
The disk decider had special handling for the single data node case, allowing any allocation (skipping watermark checks) for such clusters. This special handling can now be avoided via a setting.
henningandersen
added a commit
that referenced
this pull request
Apr 28, 2020
Contributor
|
@henningandersen , does this apply to the single hot-data node cluster? They might have more than one data node, but only one hot-data-node allowing indexing while having other warm/cold data node for storage? |
Member
|
@Leaf-Lin It only applies if there is exactly one data node. |
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jun 3, 2021
In elastic#55805, we added a setting to allow single data node clusters to respect the high watermark. This commit adds deprecation warnings to 7.x to ensure we can make only true valid in 8.0.
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jun 3, 2021
In elastic#55805, we added a setting to allow single data node clusters to respect the high watermark. In elastic#73733 we added the related deprecations. This commit ensures the only valid value for the setting is true and adds deprecations if the setting is set. The setting will be removed in a future release.
henningandersen
added a commit
that referenced
this pull request
Jun 7, 2021
In #55805, we added a setting to allow single data node clusters to respect the high watermark. This commit adds deprecation warnings to 7.x to ensure we can make only true valid in 8.0. Co-authored-by: David Turner <david.turner@elastic.co>
henningandersen
added a commit
that referenced
this pull request
Jun 7, 2021
In #55805, we added a setting to allow single data node clusters to respect the high watermark. In #73733 we added the related deprecations. This commit ensures the only valid value for the setting is true and adds deprecations if the setting is set. The setting will be removed in a future release. Co-authored-by: David Turner <david.turner@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disk decider had special handling for the single data node case,
allowing any allocation (skipping watermark checks) for such clusters.
This special handling can now be avoided via a setting.
I did not add to log a deprecation warning since:
earlyTerminatein debug mode only, affects a variety of tests.Will follow-up with a PR to flip the default and add breaking changes documentation for 8.0