Emit deprecation warning if multiple v1 templates match with a new index#55558
Conversation
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
dakrone
left a comment
There was a problem hiding this comment.
Thanks for changing this @probakowski! Before we merge it could you run a test locally with ESClientYamlTestSuite's method:
@BeforeClass
public static void initializeUseDefaultNumberOfShards() {
useDefaultNumberOfShards = usually();
}Where usually() is changed to false? This will install a global template for all the YAML tests, and I want to make sure there are no tests that are going to fail due to warnings (better to fail now before we cause CI failures)
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
…taCreateIndexService.java Co-Authored-By: Lee Hinman <dakrone@users.noreply.github.com>
|
@dakrone that was good idea, there's plenty of failures. I'll work on fixing them and request review again when done |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/2 |
dakrone
left a comment
There was a problem hiding this comment.
This LGTM, thanks Przemko! I left a comment about clarifying the warning text though, let me know what you think
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
…dex (elastic#55558) * Emit deprecation warning if multiple v1 templates match with a new index
This change adds deprecation warning when multiple v1 templates match with a new index.
This is deprecated because with v2 templates only one template can match and multiple "levels" of settings should be done using component templates.
Relates to #53101