Skip to content

[ML] Fix log spam and disable ILM/SLM history for native ML tests#55459

Merged
benwtrent merged 5 commits intoelastic:masterfrom
benwtrent:feature/ml-fix-native-tests
Apr 20, 2020
Merged

[ML] Fix log spam and disable ILM/SLM history for native ML tests#55459
benwtrent merged 5 commits intoelastic:masterfrom
benwtrent:feature/ml-fix-native-tests

Conversation

@benwtrent
Copy link
Copy Markdown
Member

This adds a dependency to ingest common. This removes the log spam resulting from basic plugins being enabled that require the common ingest processors.

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 v7.8.0 labels Apr 20, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (:ml)


protected GetFiltersAction.Response getMlFilters() {
return client().execute(GetFiltersAction.INSTANCE, new GetFiltersAction.Request()).actionGet();
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this method have to be removed as part of this PR?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be. But it was unused and I was exploring this class for fixing this problem.

Following the boy scout rule

Copy link
Copy Markdown

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent requested a review from droberts195 April 20, 2020 15:57
Copy link
Copy Markdown

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 478dd3b into elastic:master Apr 20, 2020
@benwtrent benwtrent deleted the feature/ml-fix-native-tests branch April 20, 2020 16:40
@droberts195 droberts195 changed the title [ML] fix native ML test log spam [ML] Fix log spam and disable ILM/SLM history for native ML tests Apr 20, 2020
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 20, 2020
This adds a dependency to ingest common. This removes the log spam resulting from basic plugins being enabled that require the common ingest processors.
benwtrent added a commit that referenced this pull request Apr 20, 2020
…ts (#55475)

* [ML] fix native ML test log spam (#55459)

This adds a dependency to ingest common. This removes the log spam resulting from basic plugins being enabled that require the common ingest processors.

* removing unnecessary changes

* removing unused imports

* removing unnecessary java setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants