Skip to content

Ensure not to open directory reader on transport thread#55419

Merged
dnhatn merged 1 commit intoelastic:masterfrom
dnhatn:reader-network-thread
Apr 18, 2020
Merged

Ensure not to open directory reader on transport thread#55419
dnhatn merged 1 commit intoelastic:masterfrom
dnhatn:reader-network-thread

Conversation

@dnhatn
Copy link
Copy Markdown
Member

@dnhatn dnhatn commented Apr 17, 2020

This change adds an assertion making sure that we won't accidentally open directory readers using transport threads.

@dnhatn dnhatn added >non-issue :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.8.0 v7.7.1 labels Apr 17, 2020
@dnhatn dnhatn requested a review from jimczi April 17, 2020 20:13
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

Copy link
Copy Markdown
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dnhatn
Copy link
Copy Markdown
Member Author

dnhatn commented Apr 18, 2020

Thanks Henning.

@dnhatn dnhatn merged commit c2df6f9 into elastic:master Apr 18, 2020
@dnhatn dnhatn deleted the reader-network-thread branch April 18, 2020 15:37
dnhatn added a commit that referenced this pull request Apr 21, 2020
This change adds an assertion making sure that we won't accidentally
open directory readers using transport threads.
dnhatn added a commit that referenced this pull request Apr 21, 2020
This change adds an assertion making sure that we won't accidentally
open directory readers using transport threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue v7.7.1 v7.8.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants