Fix half-float range in SupportedTypeTests#55409
Merged
polyfractal merged 3 commits intoelastic:masterfrom Apr 23, 2020
Merged
Conversation
Also adds a comment to the half-float number field type tests indicating why 70000 is used instead of 65504
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
...org/elasticsearch/search/aggregations/bucket/significant/SignificantTextAggregatorTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
polyfractal
pushed a commit
that referenced
this pull request
Apr 23, 2020
Also adds a comment to the half-float number field type tests indicating why 70000 is used instead of 65504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used a half-float mapper test as the template for how to generate half-floats in the supported-type tests (#55325), but didn't realize the particular test we were looking at was purposefully generating out-of-range half-floats. These are rounded to Infinity, which breaks the assumptions of our agg tests.
Instead, we need to generate floats < 65504. This PR also adds a comment to the mapper tests in case someone else misreads it in the future :)
Fixes #55360