Move old jdk download tests to openjdk tests#55361
Merged
rjernst merged 1 commit intoelastic:masterfrom Apr 17, 2020
Merged
Conversation
The "old jdk" tests are just testing support for downloading from oracle prior to java 12.0.1, when oracle added a hash to the url. This commit moves these tests into the openjdk tests (ie oracle download tests), since adoptopenjdk does not have any change in behavior that needs to be tested.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
added a commit
that referenced
this pull request
Apr 17, 2020
The "old jdk" tests are just testing support for downloading from oracle prior to java 12.0.1, when oracle added a hash to the url. This commit moves these tests into the openjdk tests (ie oracle download tests), since adoptopenjdk does not have any change in behavior that needs to be tested.
rjernst
added a commit
that referenced
this pull request
Apr 17, 2020
The "old jdk" tests are just testing support for downloading from oracle prior to java 12.0.1, when oracle added a hash to the url. This commit moves these tests into the openjdk tests (ie oracle download tests), since adoptopenjdk does not have any change in behavior that needs to be tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "old jdk" tests are just testing support for downloading from oracle
prior to java 12.0.1, when oracle added a hash to the url. This commit
moves these tests into the openjdk tests (ie oracle download tests),
since adoptopenjdk does not have any change in behavior that needs to be
tested.