Add validation to feature set usage name#55350
Merged
jasontedor merged 1 commit intoelastic:masterfrom Apr 16, 2020
Merged
Conversation
We do not validate the name is not null, and not empty. Even though it never should be, we had a build failure where it appears that somehow this did happen. We add some validation here, in case this really is happening, we will have a more clear indication where this is coming from, and of course, validation that name fits the implicit assumptions that it is not null and not empty.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
rjernst
approved these changes
Apr 16, 2020
|
|
||
| public Usage(String name, boolean available, boolean enabled) { | ||
| Objects.requireNonNull(name); | ||
| if (name.isEmpty()) { |
Member
There was a problem hiding this comment.
Technically isBlank() would be better incase it was just whitespace, but It's fine either way as this is very unlikely since this is not user input
jasontedor
added a commit
that referenced
this pull request
Apr 16, 2020
We do not validate the name is not null, and not empty. Even though it never should be, we had a build failure where it appears that somehow this did happen. We add some validation here, in case this really is happening, we will have a more clear indication where this is coming from, and of course, validation that name fits the implicit assumptions that it is not null and not empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not validate the name is not null, and not empty. Even though it never should be, we had a build failure where it appears that somehow this did happen. We add some validation here, in case this really is happening, we will have a more clear indication where this is coming from, and of course, validation that name fits the implicit assumptions that it is not null and not empty.