[ML] fixing and unmuting testHRDSplit test#55349
Merged
benwtrent merged 3 commits intoelastic:masterfrom Apr 17, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
526afae to
bda0117
Compare
droberts195
reviewed
Apr 17, 2020
droberts195
left a comment
There was a problem hiding this comment.
If you replace line 337:
if (responseBody.contains("\"count\":2")) {
with:
assertThat(responseBody, containsString("\"count\":2"));
then the else clause on lines 359-362 can be removed.
...le-node-tests/src/test/java/org/elasticsearch/xpack/ml/transforms/PainlessDomainSplitIT.java
Outdated
Show resolved
Hide resolved
...le-node-tests/src/test/java/org/elasticsearch/xpack/ml/transforms/PainlessDomainSplitIT.java
Outdated
Show resolved
Hide resolved
...le-node-tests/src/test/java/org/elasticsearch/xpack/ml/transforms/PainlessDomainSplitIT.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@elasticmachine update branch |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 17, 2020
This fixes the long muted testHRDSplit. Some minor adjustments for modern day elasticsearch changes :). The cause of the failure is that a new `by` field entering the model with an exceptionally high count does not cause an anomaly. We have since stopped combining the `rare` and `by` in this manner. New entries in a `by` field are not anomalous because we have no history on them yet. closes elastic#32966
benwtrent
added a commit
that referenced
this pull request
Apr 17, 2020
This fixes the long muted testHRDSplit. Some minor adjustments for modern day elasticsearch changes :). The cause of the failure is that a new `by` field entering the model with an exceptionally high count does not cause an anomaly. We have since stopped combining the `rare` and `by` in this manner. New entries in a `by` field are not anomalous because we have no history on them yet. closes #32966
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the long muted testHRDSplit. Some minor adjustments for modern day elasticsearch changes :).
The cause of the failure is that a new
byfield entering the model with an exceptionally high count does not cause an anomaly. We have since stopped combining therareandbyin this manner. New entries in abyfield are not anomalous because we have no history on them yet.closes #32966