Refactor AuditTrail for TransportRequests instead of TransportMessage#55141
Merged
albertzaharovits merged 1 commit intoelastic:masterfrom Apr 14, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-security (:Security/Audit) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-unix-docker |
albertzaharovits
added a commit
that referenced
this pull request
Apr 14, 2020
…#55141) This commit refactors the `AuditTrail` to use the `TransportRequest` as a parameter for all its audit methods, instead of the current `TransportMessage` super class. The goal is to gain access to the `TransportRequest#parentTaskId` member, so that it can be audited. The `parentTaskId` is used internally when spawning tasks that handle transport requests; in this way tasks across nodes are related by the same parent task. Relates #52314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
AuditTrailto use theTransportRequestas a parameter for all its audit methods, instead of the currentTransportMessagesuper class.The goal is to gain access to the
TransportRequest#parentTaskIdmember, so that it can be audited. TheparentTaskIdis used internally when spawning tasks that handle transport requests. In this way tasks across nodes are related by the same parent task.Relates #52314