Remove local parameter for get field mapping request#55100
Merged
ywangd merged 4 commits intoelastic:masterfrom Apr 15, 2020
Merged
Remove local parameter for get field mapping request#55100ywangd merged 4 commits intoelastic:masterfrom
ywangd merged 4 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
ywangd
commented
Apr 12, 2020
Comment on lines
+64
to
+66
| if (in.getVersion().before(Version.V_8_0_0)) { | ||
| in.readBoolean(); | ||
| } |
Member
Author
There was a problem hiding this comment.
This is not necessary if we can be sure that the request never goes across wire.
ywangd
commented
Apr 12, 2020
Comment on lines
+125
to
+127
| if (out.getVersion().before(Version.V_8_0_0)) { | ||
| out.writeBoolean(true); | ||
| } |
Member
Author
There was a problem hiding this comment.
Same here as well, not needed if the request never goes across nodes.
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
martijnvg
approved these changes
Apr 14, 2020
Member
martijnvg
left a comment
There was a problem hiding this comment.
Can you add a note to the ./docs/reference/migration/migrate_8_0/api.asciidoc file that the local param has been removed? LGTM otherwise.
Member
Author
Thanks for the reminder. It is added now. |
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 19, 2025
The `local` param for the `GetFieldMapping` API was deprecated in elastic#55014 and I think elastic#57265 aimed to propogate that deprecation to the REST API spec, but it changed `get_mapping.json` instead of `get_field_mapping.json`. elastic#55100 removed the `local` param for the _field_ mapping API so we can safely remove the field from the spec and remove the YAML test.
nielsbauman
added a commit
that referenced
this pull request
Feb 19, 2025
The `local` param for the `GetFieldMapping` API was deprecated in #55014 and I think #57265 aimed to propogate that deprecation to the REST API spec, but it changed `get_mapping.json` instead of `get_field_mapping.json`. #55100 removed the `local` param for the _field_ mapping API so we can safely remove the field from the spec and remove the YAML test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local parameter of get field mapping request is marked as deprecated in 7.x.
This PR removes it for the next major.