Passthrough special characters in thread pool docs#55080
Merged
jasontedor merged 2 commits intoelastic:masterfrom Apr 10, 2020
Merged
Passthrough special characters in thread pool docs#55080jasontedor merged 2 commits intoelastic:masterfrom
jasontedor merged 2 commits intoelastic:masterfrom
Conversation
Some of these characters are special to Asciidoctor and they ruin the rendering on this page. Instead, we use a macro to passthrough these characters without Asciidoctor applying any subtitutions to them. This commit then addresses some rendering issues in the thread pool docs.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
jrodewig
reviewed
Apr 10, 2020
jrodewig
approved these changes
Apr 10, 2020
Contributor
jrodewig
left a comment
There was a problem hiding this comment.
LGTM. Left one non-blocking nit for the write thread pool definition.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
jasontedor
added a commit
that referenced
this pull request
Apr 10, 2020
Some of these characters are special to Asciidoctor and they ruin the rendering on this page. Instead, we use a macro to passthrough these characters without Asciidoctor applying any subtitutions to them. This commit then addresses some rendering issues in the thread pool docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these characters are special to Asciidoctor and they ruin the rendering on this page. Instead, we use a macro to passthrough these characters without Asciidoctor applying any subtitutions to them. This commit then addresses some rendering issues in the thread pool docs.