Skip to content

Fixes for IntelliJ IDEA 2020.1 support#55077

Merged
mark-vieira merged 2 commits intoelastic:masterfrom
mark-vieira:intellij-2020.1-fixes
Apr 10, 2020
Merged

Fixes for IntelliJ IDEA 2020.1 support#55077
mark-vieira merged 2 commits intoelastic:masterfrom
mark-vieira:intellij-2020.1-fixes

Conversation

@mark-vieira
Copy link
Copy Markdown
Contributor

Some changes in how IntelliJ 2020.1 resolved dependencies caused some build failures in the IDE due to missing dependencies in QA projects. This makes those dependencies explicit to workaround the problem.

Additionally, I noticed that on a clean import the build will fail due to the HLRC shadow jar not having been built (our wildfly qa tests depend on this). So now and import will run the task to build that jar ensuring it's always available even if you haven't manually built it already.

@mark-vieira mark-vieira added the :Delivery/Build Build or test infrastructure label Apr 10, 2020
@mark-vieira mark-vieira requested a review from rjernst April 10, 2020 16:45
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

@mark-vieira mark-vieira merged commit 3966191 into elastic:master Apr 10, 2020
@mark-vieira mark-vieira deleted the intellij-2020.1-fixes branch April 10, 2020 18:38
mark-vieira added a commit that referenced this pull request Apr 10, 2020
# Conflicts:
#	x-pack/qa/evil-tests/build.gradle
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants