Define aarch64 packaging test tasks#55073
Merged
pugnascotia merged 7 commits intoelastic:masterfrom Apr 15, 2020
Merged
Conversation
We added tasks to build an ARM distribution and Docker image, but didn't provide any way to run packaging tests against them. Add extra loops on the possible Architecture values, and skip tasks that can't be run on the current Architecture.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
Also rename some boolean getters to have names that reflect the return type, since it makes the resulting code clearer.
mark-vieira
requested changes
Apr 13, 2020
Contributor
mark-vieira
left a comment
There was a problem hiding this comment.
Added some comments.
buildSrc/src/main/java/org/elasticsearch/gradle/DistributionDownloadPlugin.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/ElasticsearchDistribution.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/ElasticsearchDistribution.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/test/DistroTestPlugin.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/test/DistroTestPlugin.java
Show resolved
Hide resolved
pugnascotia
added a commit
that referenced
this pull request
Apr 15, 2020
Backport of #55073. We added tasks to build an ARM distribution and Docker image, but didn't provide any way to run packaging tests against them. Add extra loops on the possible Architecture values, and skip tasks that can't be run on the current Architecture.
pugnascotia
added a commit
that referenced
this pull request
Apr 15, 2020
Backport of #55073. We added tasks to build an ARM distribution and Docker image, but didn't provide any way to run packaging tests against them. Add extra loops on the possible Architecture values, and skip tasks that can't be run on the current Architecture.
Contributor
Author
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added tasks to build an ARM distribution and Docker image, but didn't
provide any way to run packaging tests against them. Add extra loops on
the possible Architecture values, and skip tasks that can't be run on
the current Architecture.
Part of #54925.