Skip to content

Fix Broken Math in S3 Retries Tests#54952

Merged
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:fix-broken-math-s3-retries-tests
Apr 8, 2020
Merged

Fix Broken Math in S3 Retries Tests#54952
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:fix-broken-math-s3-retries-tests

Conversation

@original-brownbear
Copy link
Copy Markdown
Contributor

If we run into length == 0 we trip an assertion in randomIntBetween(0, length -1).

If we run into `length == 0` we trip an assertion in `randomIntBetween(0, length -1)`.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.8.0 labels Apr 8, 2020
@original-brownbear original-brownbear requested a review from tlrx April 8, 2020 13:05
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run elasticsearch-ci/packaging-sample-unix-archives
Jenkins run elasticsearch-ci/packaging-sample-unix-packages

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear original-brownbear merged commit 73b5f58 into elastic:master Apr 8, 2020
@original-brownbear original-brownbear deleted the fix-broken-math-s3-retries-tests branch April 8, 2020 17:41
original-brownbear added a commit that referenced this pull request Apr 8, 2020
If we run into `length == 0` we trip an assertion in `randomIntBetween(0, length -1)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants