[DOCS] EQL: Document between function#54950
Merged
jrodewig merged 2 commits intoelastic:masterfrom Apr 8, 2020
jrodewig:docs__eql-fn-between
Merged
[DOCS] EQL: Document between function#54950jrodewig merged 2 commits intoelastic:masterfrom jrodewig:docs__eql-fn-between
between function#54950jrodewig merged 2 commits intoelastic:masterfrom
jrodewig:docs__eql-fn-between
Conversation
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
aleksmaus
approved these changes
Apr 8, 2020
Contributor
There was a problem hiding this comment.
LGTM. Thank you!
One possible change in the future is handling of nulls where the value is expected.
Presently for between function you get null returned only if the source/first parameter is null and get the error if you try to pass nulls for the other parameters. Some other functions return null instead of error if other parameters are null.
We suppose to agree on this shortly and make it consistent across the functions.
Contributor
Author
|
Thanks @aleksmaus! I went ahead a removed some of the null handling examples with ba6c2b6. This should help future proof things a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the EQL
betweenfunction.Relates to #54277 and #54135