Prevent putting V2 index template when overlapping with existing template#54933
Merged
probakowski merged 13 commits intoelastic:masterfrom Apr 10, 2020
Merged
Conversation
…late This change prevents putting V2 index template when it would overlap with existing V2 template of the same priority Relates to elastic#53101
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
This reverts commit 9f3732a.
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
dakrone
approved these changes
Apr 8, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
This LGTM, thanks Przemko! I left a few minor suggestions but nothing that needs more reviewing
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
…taIndexTemplateService.java Co-Authored-By: Lee Hinman <dakrone@users.noreply.github.com>
andreidan
reviewed
Apr 9, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine update branch |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Apr 10, 2020
…late (elastic#54933) * Prevent putting V2 index template when overlapping with existing template This change prevents putting V2 index template when it would overlap with existing V2 template of the same priority Relates to elastic#53101
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Apr 21, 2020
This change fixes problem with updating Index Templates V2. Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so new template was always clashing with itself unless patterns were not changed completely.
probakowski
added a commit
that referenced
this pull request
Apr 22, 2020
This change fixes problem with updating Index Templates V2. Validatation added in #54933 didn't filter list of conflicting templates correctly so new template was always clashing with itself unless patterns were not changed completely.
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Apr 22, 2020
This change fixes problem with updating Index Templates V2. Validatation added in elastic#54933 didn't filter list of conflicting templates correctly so new template was always clashing with itself unless patterns were not changed completely.
probakowski
added a commit
that referenced
this pull request
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents putting V2 index template when it would overlap with existing V2 template of the same priority
Relates to #53101