Add allowed warnings to index template composition tests#54916
Merged
dakrone merged 2 commits intoelastic:masterfrom Apr 8, 2020
Merged
Add allowed warnings to index template composition tests#54916dakrone merged 2 commits intoelastic:masterfrom
dakrone merged 2 commits intoelastic:masterfrom
Conversation
We occasionally add a global template for our YAML tests, and this can cause warnings for these template tests. This commit adds these warnings so they don't cause test failures. Resolves elastic#54822
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
Member
Author
|
@elasticmachine update branch |
andreidan
approved these changes
Apr 8, 2020
Contributor
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this Lee
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Apr 8, 2020
We occasionally add a global template for our YAML tests, and this can cause warnings for these template tests. This commit adds these warnings so they don't cause test failures. Resolves elastic#54822 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We occasionally add a global template for our YAML tests, and this can cause warnings for these
template tests. This commit adds these warnings so they don't cause test failures.
Resolves #54822