Lazy test cluster module and plugins#54852
Merged
jakelandis merged 6 commits intoelastic:masterfrom Apr 8, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
mark-vieira
approved these changes
Apr 7, 2020
Contributor
mark-vieira
left a comment
There was a problem hiding this comment.
Looks great! Thanks for taking care of this.
buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
Outdated
Show resolved
Hide resolved
rjernst
reviewed
Apr 7, 2020
buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/TestClusterConfiguration.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
rjernst
approved these changes
Apr 8, 2020
Member
rjernst
left a comment
There was a problem hiding this comment.
It's nice to see reduced usage of afterEvaluate in PluginBuildPlugin! LGTM.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 10, 2020
This change converts the module and plugin parameters for testClusters to be lazy. Meaning that the values are not resolved until they are actually used. This removes the requirement to use project.afterEvaluate to be able to resolve the bundle artifact. Note - this does not completely remove the need for afterEvaluate since it is still needed for the custom resource extension.
jakelandis
added a commit
that referenced
this pull request
Apr 13, 2020
This change converts the module and plugin parameters for testClusters to be lazy. Meaning that the values are not resolved until they are actually used. This removes the requirement to use project.afterEvaluate to be able to resolve the bundle artifact. Note - this does not completely remove the need for afterEvaluate since it is still needed for the custom resource extension.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 13, 2020
…5087) This change converts the module and plugin parameters for testClusters to be lazy. Meaning that the values are not resolved until they are actually used. This removes the requirement to use project.afterEvaluate to be able to resolve the bundle artifact. Note - this does not completely remove the need for afterEvaluate since it is still needed for the custom resource extension.
jakelandis
added a commit
that referenced
this pull request
Apr 13, 2020
This change converts the module and plugin parameters for testClusters to be lazy. Meaning that the values are not resolved until they are actually used. This removes the requirement to use project.afterEvaluate to be able to resolve the bundle artifact. Note - this does not completely remove the need for afterEvaluate since it is still needed for the custom resource extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change converts the module and plugin parameters
for testClusters to be lazy. Meaning that the values
are not resolved until they are actually used. This
removes the requirement to use project.afterEvaluate to
be able to resolve the bundle artifact.
Note - this does not completely remove the need for afterEvaluate
since it is still needed for the custom resource extension.