QL: Introduce infrastructure for substituting functions#54795
Merged
costin merged 3 commits intoelastic:masterfrom Apr 6, 2020
Merged
QL: Introduce infrastructure for substituting functions#54795costin merged 3 commits intoelastic:masterfrom
costin merged 3 commits intoelastic:masterfrom
Conversation
Some functions act as shortcuts for more verbose declarations (sometimes with certain constraints). This PR removes the boilerplate around declaring such functions as well as a dedicated rule for the optimizer to perform the actual substitution. Fix elastic#54334
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
aleksmaus
approved these changes
Apr 6, 2020
matriv
approved these changes
Apr 6, 2020
Contributor
matriv
left a comment
There was a problem hiding this comment.
LGTM. Maybe in the future SurrogateFunction could be an iface so that can be used in other function hieararchies.
rw-access
approved these changes
Apr 6, 2020
into a base class. It would have been nice to be use it as a mixin but we live with what we have.
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions act as shortcuts for more verbose declarations (sometimes
with certain constraints). This PR removes the boilerplate around
declaring such functions as well as a dedicated rule for the optimizer
to perform the actual substitution.
Fix #54334