Skip to content

Test: Include ML ILM policy in EsRestTest#54773

Merged
costin merged 1 commit intoelastic:masterfrom
costin:fix/54759
Apr 5, 2020
Merged

Test: Include ML ILM policy in EsRestTest#54773
costin merged 1 commit intoelastic:masterfrom
costin:fix/54759

Conversation

@costin
Copy link
Copy Markdown
Member

@costin costin commented Apr 5, 2020

This should avoid REST failures caused by the inability to delete said
policy
Fix #54759

This should avoid REST failures caused by the inability to delete said
policy
Fix elastic#54759
@costin costin added the >test Issues or PRs that are addressing/adding tests label Apr 5, 2020
@costin
Copy link
Copy Markdown
Member Author

costin commented Apr 5, 2020

I've added multiple folks not sure who's best in reviews this small change.
I've used @dakrone advice which seems to be working on my machine (waiting for the CI).
@droberts195 can you please take a look at the fix and add the needed version - since the failure is recent, does it need backporting?

Thanks,

Copy link
Copy Markdown
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@costin costin merged commit 3ba5e02 into elastic:master Apr 5, 2020
@costin costin deleted the fix/54759 branch April 5, 2020 17:04
costin added a commit that referenced this pull request Apr 5, 2020
This should avoid REST failures caused by the inability to delete said
policy
Fix #54759

(cherry picked from commit 3ba5e02)
@costin
Copy link
Copy Markdown
Member Author

costin commented Apr 5, 2020

Thanks @jasontedor . Pushed to master and backported to 7.x

@droberts195
Copy link
Copy Markdown

Thanks for fixing this @costin!

@droberts195
Copy link
Copy Markdown

@przemekwitek please can you check if this also needs backporting to 7.7 since that's when we added the ILM policy. I guess it was a new test added for 7.8 that caused the problem to occur regularly, but maybe we could suffer it occasionally with other tests on 7.7 too?

@przemekwitek
Copy link
Copy Markdown

@przemekwitek please can you check if this also needs backporting to 7.7 since that's when we added the ILM policy. I guess it was a new test added for 7.8 that caused the problem to occur regularly, but maybe we could suffer it occasionally with other tests on 7.7 too?

I think I'll backport it just in case. It shouldn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Failure in {p0=ml/data_frame_analytics_crud/Test put regression given negative lambda}

5 participants