Add generic Set support to streams#54769
Merged
rjernst merged 6 commits intoelastic:masterfrom Apr 13, 2020
Merged
Conversation
This commit adds support for reading and writing sets as generic values in stream input and output. closes elastic#54708
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
original-brownbear
approved these changes
Apr 5, 2020
| import java.util.Map; | ||
| import java.util.Objects; | ||
| import java.util.Set; | ||
| import java.util.function.Consumer; |
Contributor
There was a problem hiding this comment.
This import still trips checkstyle
| case 24: | ||
| return readCollection(StreamInput::readGenericValue, LinkedHashSet::new, Collections.emptySet()); | ||
| case 25: | ||
| return readCollection(StreamInput::readGenericValue, HashSet::new, Collections.emptySet()); |
Contributor
There was a problem hiding this comment.
I think you can just make this readSet(StreamInput::readGenericValue)?
Member
Author
There was a problem hiding this comment.
It could work for the HashSet version, but I think it is good to have the symmetry with with the LInkedHashSet above.
Contributor
There was a problem hiding this comment.
fair point :) LGTM
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 13, 2020
This commit adds support for reading and writing sets as generic values in stream input and output. closes elastic#54708
rjernst
added a commit
that referenced
this pull request
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for reading and writing sets as generic values
in stream input and output.
closes #54708