[ML] inference only persist if there are stats#54752
Merged
benwtrent merged 7 commits intoelastic:masterfrom Apr 13, 2020
Merged
[ML] inference only persist if there are stats#54752benwtrent merged 7 commits intoelastic:masterfrom
benwtrent merged 7 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
Member
Author
|
I am adding this directly in the backport of the original stats persistence PR: EDIT: No I am not. Will backport this PR instead |
Member
Author
|
@elasticmachine update branch |
…f github.com:benwtrent/elasticsearch into feature/ml-inference-only-persist-if-there-are-stats
…nce-only-persist-if-there-are-stats
| modelId, | ||
| null, | ||
| timeStamp == null ? Instant.now() : Instant.ofEpochMilli(Double.valueOf(timeStamp.getValue()).longValue()) | ||
| timeStamp == null || (Numbers.isValidDouble(timeStamp.getValue()) == false) ? |
Contributor
There was a problem hiding this comment.
Is it possible for timestamp to be an invalid number here?
Member
Author
There was a problem hiding this comment.
Yes, it is. The agg could have not found any values, or the values they found were changed somehow. This type of check is effectively what aggs do under the hood when they serialize to JSON to protect against goofy doubles. The difference here is that we write out now() instead of null
...k/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/TrainedModelStatsService.java
Show resolved
Hide resolved
dimitris-athanasiou
approved these changes
Apr 13, 2020
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Second time lucky!
Member
Author
|
run elasticsearch-ci/1 |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 13, 2020
We needlessly send documents to be persisted. If there are no stats added, then we should not attempt to persist them. Also, this PR fixes the race condition that caused issue: elastic#54786
benwtrent
added a commit
that referenced
this pull request
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needlessly send documents to be persisted. If there are no stats added, then we should not attempt to persist them.
closes #54786