HLRC support for Component Templates APIs#54635
Merged
probakowski merged 20 commits intoelastic:masterfrom Apr 6, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
Contributor
Author
|
@elasticmachine update branch |
dakrone
requested changes
Apr 2, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
Thanks @probakowski, I left some comments, in particular, I'm curious why we have some many different types of parsing options for ComponentTemplate (the source methods), I think maybe instead it would be better to stick with providing a fully-built ComponentTemplate object, and optionally providing a builder for a ComponentTemplate (in the ComponentTemplate class itself) if we want to be friendlier
client/rest-high-level/src/main/java/org/elasticsearch/client/ClusterClient.java
Outdated
Show resolved
Hide resolved
...igh-level/src/main/java/org/elasticsearch/client/indices/ComponentTemplatesExistRequest.java
Outdated
Show resolved
Hide resolved
...high-level/src/main/java/org/elasticsearch/client/indices/GetComponentTemplatesResponse.java
Show resolved
Hide resolved
...high-level/src/main/java/org/elasticsearch/client/indices/GetComponentTemplatesResponse.java
Outdated
Show resolved
Hide resolved
...t-high-level/src/main/java/org/elasticsearch/client/indices/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...t-high-level/src/main/java/org/elasticsearch/client/indices/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...t-high-level/src/main/java/org/elasticsearch/client/indices/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...t-high-level/src/main/java/org/elasticsearch/client/indices/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...t-high-level/src/main/java/org/elasticsearch/client/indices/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
dakrone
approved these changes
Apr 3, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one more minor comment about which class to implement for the request
...t-high-level/src/main/java/org/elasticsearch/client/indices/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Apr 6, 2020
* HLRC support for Component Templates * hlrc * hlrc * merge fix * removed unused import * checkstyle fixes * metaData -> metadata * move to ClusterClient * checkstyle fixes * checkstyle fixes * checkstyle fixes * method in spec fixed * PR comments * PR comments * PR comments * unused imports fixed * review comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
probakowski
added a commit
that referenced
this pull request
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds High Level Rest Client support for Component Templates.
Relates to #53101
Added
>non-issuelabel as component templates are still behind feature flag