Add allowed warnings to index template v2 YAML tests#54535
Merged
dakrone merged 1 commit intoelastic:7.xfrom Mar 31, 2020
Merged
Add allowed warnings to index template v2 YAML tests#54535dakrone merged 1 commit intoelastic:7.xfrom
dakrone merged 1 commit intoelastic:7.xfrom
Conversation
There is a setting in `ESClientYamlSuiteTestCase` under `usually()` that can install a `global` template changing the number of shards for all indices. This can cause warnings when installing v2 templates (see elastic#54367). This adds these as optional warnings so they don't cause failures regardless of whether the global template is installed or not. These warnings can be removed when our internal template usage has been moved to index templates v2 Relates to elastic#53101
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 31, 2020
There is a setting in `ESClientYamlSuiteTestCase` under `usually()` that can install a `global` template changing the number of shards for all indices. This can cause warnings when installing v2 templates (see elastic#54367). This adds these as optional warnings so they don't cause failures regardless of whether the global template is installed or not. These warnings can be removed when our internal template usage has been moved to index templates v2 Relates to elastic#53101
dakrone
added a commit
that referenced
this pull request
Mar 31, 2020
There is a setting in `ESClientYamlSuiteTestCase` under `usually()` that can install a `global` template changing the number of shards for all indices. This can cause warnings when installing v2 templates (see #54367). This adds these as optional warnings so they don't cause failures regardless of whether the global template is installed or not. These warnings can be removed when our internal template usage has been moved to index templates v2 Relates to #53101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a setting in
ESClientYamlSuiteTestCaseunderusually()that can install aglobaltemplate changing the number of shards for all indices. This can cause warnings when installing v2
templates (see #54367). This adds these as optional warnings so they don't cause failures regardless
of whether the global template is installed or not.
These warnings can be removed when our internal template usage has been moved to index templates v2
Relates to #53101