Skip to content

[DOCS] Reformat keyword_repeat token filter#54428

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__reformat-keyword-repeat-tokenfilter
Apr 1, 2020
Merged

[DOCS] Reformat keyword_repeat token filter#54428
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__reformat-keyword-repeat-tokenfilter

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

Makes the following changes to the keyword_repeat token filter docs:

  • Rewrites description and adds Lucene link
  • Adds detailed analyze example
  • Rewrites analyzer example

@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens labels Mar 30, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In future I think we want to point people towards the conditional filter, which is a more general solution, but I think there are still some corners where this isn't a good replacement so let's leave things as they are for now.

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Apr 1, 2020

Thanks @romseygeek.

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Apr 1, 2020

Backport commits

master 28cfb8c
7.x 21abc31
7.7 1a5d508
7.6 2119fb8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants